fix(CI): cppcheck failure step (#17240)

* feat: add cppcheck for scripts

* fix: cppcheck step failure

* trigger cppcheck build, it should fail

* fix: cppcheck should succeed

* fix: cppcheck

.github/workflows/cpp-check.yml

@@ -26,12 +26,9 @@ jobs:
         run: |
           sudo apt update -y
           sudo apt install -y cppcheck
-          cppcheck --force --inline-suppr \
-            -i src/server/game/Achievements/AchievementMgr.cpp \
-            -i src/server/game/AuctionHouse/AuctionHouseMgr.cpp \
-            -i src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp \
-            -i src/server/game/DungeonFinding/LFGMgr.cpp \
-            -i src/server/game/Entities/GameObject/GameObject.cpp \
-            -i src/server/game/Entities/Pet/Pet.cpp \
-            -i src/server/game/Entities/Player/Player.cpp \
-            src/
+          cppcheck --force --inline-suppr --suppressions-list=./.suppress.cppcheck src/ --output-file=report.txt
+
+          if [ -s report.txt ]; then  # if file is not empty
+            cat report.txt
+            exit 1 # let github action fails
+          fi

.suppress.cppcheck

@@ -0,0 +1 @@
+cppcheckError

src/server/apps/authserver/Server/AuthSession.h

@@ -45,6 +45,7 @@ enum AuthStatus
     STATUS_CLOSED
 };
 
+// cppcheck-suppress ctuOneDefinitionRuleViolation
 struct AccountInfo
 {
     void LoadResult(Field* fields);

src/server/game/Server/Packets/MiscPackets.h

@@ -57,6 +57,7 @@ namespace WorldPackets
         class AC_GAME_API PlayMusic final : public ServerPacket
         {
         public:
+            // cppcheck-suppress missingReturn
             PlayMusic() : ServerPacket(SMSG_PLAY_MUSIC, 4) { }
             PlayMusic(uint32 soundKitID) : ServerPacket(SMSG_PLAY_MUSIC, 4), SoundKitID(soundKitID) { }
 
@@ -68,6 +69,7 @@ namespace WorldPackets
         class AC_GAME_API PlayObjectSound final : public ServerPacket
         {
         public:
+            // cppcheck-suppress missingReturn
             PlayObjectSound() : ServerPacket(SMSG_PLAY_OBJECT_SOUND, 4 + 8) { }
             PlayObjectSound(ObjectGuid const& sourceObjectGUID, uint32 soundKitID)
                 : ServerPacket(SMSG_PLAY_OBJECT_SOUND, 4 + 8), SourceObjectGUID(sourceObjectGUID), SoundKitID(soundKitID) { }
@@ -82,6 +84,7 @@ namespace WorldPackets
         class AC_GAME_API Playsound final : public ServerPacket
         {
         public:
+            // cppcheck-suppress missingReturn
             Playsound() : ServerPacket(SMSG_PLAY_SOUND, 4) { }
             Playsound(uint32 soundKitID) : ServerPacket(SMSG_PLAY_SOUND, 4), SoundKitID(soundKitID) { }